Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

Ethplorer account bug with rates not being recognized as Doubles #190

Closed
wolffan opened this issue Oct 25, 2017 · 2 comments
Closed

Ethplorer account bug with rates not being recognized as Doubles #190

wolffan opened this issue Oct 25, 2017 · 2 comments
Assignees
Labels

Comments

@wolffan
Copy link
Contributor

wolffan commented Oct 25, 2017

What is the current behavior?
You can't add an ERC20 compatible wallet
Actual problem is that ethplore api changed and now rate is a string, not a number

If the current behavior is a bug, please provide the steps to reproduce starting from "launch Balance". If possible, please include a screenshot or a video.
add a wallet that contains 0.something as rate

What is the expected behavior?
Should be able to add any ERC20 wallet

Which version of Balance is affected by this issue? Did this work in previous versions of Balance?
Current master

@wolffan wolffan added the bug label Oct 25, 2017
@wolffan wolffan self-assigned this Oct 25, 2017
@wolffan
Copy link
Contributor Author

wolffan commented Oct 25, 2017

working pr with updated json models for tests if someone wants to chip in: https://github.com/balancemymoney/balance-open/pull/191

@wolffan
Copy link
Contributor Author

wolffan commented Oct 26, 2017

@wolffan wolffan closed this as completed Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant