Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truly delete account details #22

Closed
chadwhitacre opened this issue Aug 21, 2012 · 5 comments
Closed

truly delete account details #22

chadwhitacre opened this issue Aug 21, 2012 · 5 comments

Comments

@chadwhitacre
Copy link
Contributor

I have a button on my site that says "Delete my Credit Card - Your credit card details will immediately be completely purged from Gittip." However, I think this might be a lie. Am I right that cards in Balanced can only be invalidated, not deleted? I need them to be deleted. Is there a reason they can't be deleted?

@mjallday
Copy link
Contributor

This issue should include being able to properly delete cards, bank accounts, and (test) marketplaces.

@matin - Can you edit the description to "Truly delete resources"?

The issue that we run into is that once a resource, such as a card, is used for an operation it's very hard to properly perform a DELETE operation on it. If we delete the card, what do we show as the source for the payments associated with that card?

My suggestion is that we remove the vaulted card details (satisfying the requirement of purging the data) while retaining the card name / last_four and mark it deleted. This card would then no longer be returned via a GET on the cards index URI but it would still be able to be returned if you did a GET on the actual URI of the card itself. It would return a deleted_at field which shows the date the DELETE operation was performed.

For other resources the DELETE operation would be similar, a hard delete if there are no dependencies, a soft delete (marked deleted and not returned via index operations) if other items depend on it.

@matin
Copy link
Member

matin commented Aug 22, 2012

@mjallday create another issue and make them related. It should not be generalized. You should never be able to create a debit, hold, credit, or refund

@mjallday
Copy link
Contributor

Moving discussion to #29

@matin
Copy link
Member

matin commented Aug 22, 2012

#29

@matin
Copy link
Member

matin commented Sep 17, 2012

duplicate of #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants