Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to newest version of requests #26

Closed
jrus opened this issue Feb 15, 2013 · 4 comments
Closed

update to newest version of requests #26

jrus opened this issue Feb 15, 2013 · 4 comments

Comments

@jrus
Copy link
Contributor

jrus commented Feb 15, 2013

The requests library has gone through big changes since the April 2012 version the balanced python client requires: http://pypi.python.org/pypi/requests#history

It had some backwards incompatible changes w/ the big refactor/rewrite 1.0 release, but that's now 2 months ago, so it might be stable enough to rely on by now. Might take a bit of reworking of our code, I don’t know how hard it would be.

Also worth investigating is version 0.14.2 of Requests from the end of October, the last version before the big refactor.

When trying to run on google app engine, the python client currently fails, because requests can't find a list of certificate authority keys, and therefore raises an exception. It’s possible to work around this by leaving the same requests version and modifying the balanced python client. But it also might fix things to just use a newer version of the library. I haven’t done much testing of it.

@mjallday
Copy link
Contributor

I'm working on a branch to allow the latest version of requests but 1.x refactoring appears to have broken the documented behavior that we rely on. We can work around easily enough but am going to pause here for air.

@mjallday
Copy link
Contributor

@whit537 https://github.com/balanced/balanced-python/tree/requests-1.1.0 - One of the requests maintainers solved my issue on the thread referenced above.

@chadwhitacre
Copy link
Contributor

Nice. :)

@mjallday
Copy link
Contributor

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants