Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication if filtering is using a valid field or not #26

Open
mjallday opened this issue Aug 3, 2012 · 4 comments
Open

No indication if filtering is using a valid field or not #26

mjallday opened this issue Aug 3, 2012 · 4 comments

Comments

@mjallday
Copy link
Contributor

mjallday commented Aug 3, 2012

The Balanced API only filters on a subset of the returned fields.

    @hold = Balanced::Hold.find(:first, id: hold.id)

This code looks like it will return the first hold with the associated ID. However, the API doesn't allow filtering on the ID field.

Balanced should either throw an error in the balanced-ruby library or document which fields are indexable.

@mjallday
Copy link
Contributor Author

mjallday commented Aug 3, 2012

Runable example showing how this can bite you in the butt - https://gist.github.com/47b943f57096b4a9c471

@zealoushacker
Copy link
Contributor

👍

@mahmoudimus
Copy link
Contributor

So this is actually an API issue silently ignoring fields it's not indexing on -- not a Ruby client issue. We'll track the progress of this issue with this github ticket and update when we fix and prioritize internally.

@mjallday
Copy link
Contributor Author

Opened a ticket on the balanced-api repo which will need to be tackled first.

balanced/balanced-api#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants