Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

John/v2 package linear refactor #143

Merged
merged 6 commits into from
Sep 20, 2021
Merged

John/v2 package linear refactor #143

merged 6 commits into from
Sep 20, 2021

Conversation

johngrantuk
Copy link
Member

No description provided.

@johngrantuk johngrantuk marked this pull request as ready for review September 17, 2021 11:14
sergioyuhjtman
sergioyuhjtman approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@sergioyuhjtman sergioyuhjtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes improve the code.
Some simple remarks on how the code might be improved further will be commented to the author elsewhere.

@johngrantuk johngrantuk merged commit 3f24fae into john/v2-package-linear Sep 20, 2021
@johngrantuk johngrantuk deleted the john/v2-package-linear-refactor branch September 20, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergioyuhjtman sergioyuhjtman sergioyuhjtman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johngrantuk @sergioyuhjtman