Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define proper event logging #11

Closed
nventuro opened this issue Sep 8, 2020 · 1 comment
Closed

Define proper event logging #11

nventuro opened this issue Sep 8, 2020 · 1 comment

Comments

@nventuro
Copy link
Contributor

nventuro commented Sep 8, 2020

v1 relied on LOG_CALL and family to log all external calls made to any contract in the system. We may want to move away from that and have more intent-focused events instead.
@nventuro nventuro mentioned this issue Sep 8, 2020
Merged
@nventuro nventuro added this to the AMM Code Freeze milestone Nov 11, 2020
@nventuro
Copy link
Contributor Author

This should be based on needs from our app and required subgraph support. We should also be mindful of how much extra gas these events would add.

@nventuro nventuro removed this from the AMM Code Freeze milestone Dec 4, 2020
joaobrunoah referenced this issue in joaobrunoah/balancer-v2-monorepo Nov 22, 2022
@joaobrunoah
Add rebalancer to erc4626 linear pool (#11)
9638192 
* Fork Test of ERC4626

* Removing ERC4626 console.log

* Fixing Tests

* Fixing Linear Pool vulnerability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nventuro