Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable Pool Tokenizer #43

Closed
nventuro opened this issue Oct 13, 2020 · 2 comments · Fixed by #74
Closed

Immutable Pool Tokenizer #43

nventuro opened this issue Oct 13, 2020 · 2 comments · Fixed by #74
Assignees
@nventuro
Milestone
AMM release - fir...

Comments

@nventuro
Copy link
Contributor

We should have a sample pool controller that tokenizes pool participation, without any form of adminship or configurability - the token makeup of the pool will never change, nor will the trading strategy.

This would be equivalent to Balancer v1 shared pools.
@nventuro nventuro mentioned this issue Oct 13, 2020
Closed
@gtaschuk
Copy link
Contributor

I believe this is already implemented in the form of contracts/ImmutablePoolTokenizer.sol - let me know if theres anything else I should do with it, @nventuro

@nventuro
Copy link
Contributor Author

You are right - it slipped my mind. Let's wait until we merge the vault-controller API refactor I have going on, and then we'll close this.

@nventuro nventuro self-assigned this Oct 26, 2020
@nventuro nventuro mentioned this issue Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nventuro nventuro

Labels
None yet
Projects
None yet
Milestone
AMM release - first auditor engagemen...
Development

Successfully merging a pull request may close this issue.

Pool controller API rework balancer/balancer-v2-monorepo
2 participants
@gtaschuk @nventuro