Skip to content
This repository has been archived by the owner on Mar 26, 2023. It is now read-only.

Need support for https #46

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 6 comments
Closed

Need support for https #46

GoogleCodeExporter opened this issue Mar 14, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Use the translate code on a page that is served via https protocol.

What is the expected output? What do you see instead?
Get a warning message in IE about content referenced that is not protected. It 
is trying to access http://www.google.com/jsapi? in the 
jquery.translate-1.4.5.min.js file.

Please provide any additional information below.
I have hacked our local jquery.translate file to replace the 
"http://www.google.com/jsapi?" code piece with the following:
("https:" == document.location.protocol) ? "https://ssl." : "http://www.") + 
"google.com/jsapi?"

Original issue reported on code.google.com by schwa...@gmail.com on 19 Aug 2010 at 7:26

@GoogleCodeExporter
Copy link
Author

Sorry, the added code to get it to work was:
(("https:" == document.location.protocol) ? "https://" : "http://" + 
"www.google.com/jsapi?"

Original comment by schwa...@gmail.com on 19 Aug 2010 at 7:31

@GoogleCodeExporter
Copy link
Author

Ok, this comment submission is stripping the " off after the https:// and the 
") after the http://

Original comment by schwa...@gmail.com on 19 Aug 2010 at 7:34

@GoogleCodeExporter
Copy link
Author

Thanks, I get it :) I'll upload a new version in the following days. (I'd like 
to fix a couple of other things as well.)

Original comment by balazs.endresz on 19 Aug 2010 at 8:09

  • Changed state: Accepted
  • Added labels: Priority-High
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Awesome, thank you! Code rocks btw, thanks a ton for writing it and releasing 
it!

Original comment by schwa...@gmail.com on 19 Aug 2010 at 8:36

@GoogleCodeExporter
Copy link
Author

Sure, open source is the best/easiest way to catch bugs :)
It should be fixed now in v1.4.7.

Original comment by balazs.endresz on 20 Aug 2010 at 8:17

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Issue 50 has been merged into this issue.

Original comment by balazs.endresz on 27 Aug 2010 at 11:22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant