Wrong NOT NULL criteria on MYSQL

[Medioman92]

Node version: 10.4.1
Sails version (sails): 1.1.0
ORM hook version (sails-hook-orm): 2.1.1
DB adapter & version (sails-mysql): 1.0.1

---

Hi, i'm trying execute a simple find on MySQL 5.7.25 looking for records where a field is not null. Waterline ORM should use "IS NOT NULL" instead of "!=" to compare NULLS in the generated SQL query. This is the controller's relevant portion of code:

let someRecord = await User.find({
      where: {
        and: [
          {USER_ID: req.param('USER_ID')},
          {
            or: [
              {END_DATE: {'!=': null}},
              {END_SESSION_DATE: {'!=': null}},
            ]
          }
        ],
      },
      limit: 3
    });

This is the generated SQL query:

select *
from USER
where USER_ID = 1
  and (END_DATE != NULL or END_SESSION_DATE != NULL)
limit 3

If you try to use {FIELD:null} as criteria is correctly translated to IS NULL instead of "="
Is this a regression of some kind ? it seems a pretty bad bug to me

[sailsbot]

@Medioman92 Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[johnabrams7]

@Medioman92 Thanks for bringing this to attention, have you tried this out in our latest MySQL adapter sails-sql? This one is honestly ready to use for MySQL in production and features updates to the boolean and NULL criteria. PostgreSQL support is particularly still in development and only recommended for testing at the moment.

Edit: Sorry for the repeat recommendation, just noticed I mentioned that in a previous recent post we shared - were you able to give it a go?

[Medioman92]

I waited since we’re actually in pre-production phase with our product.
If it’s ready for production with mysql i’ll give it a try and let you know

[Medioman92]

@johnabrams7 seems working just fine with sails-sql