Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to enable double-slashes in URLs? #6806

Open
alxndrsn opened this issue Jul 8, 2019 · 2 comments
Open

Is there a way to enable double-slashes in URLs? #6806

alxndrsn opened this issue Jul 8, 2019 · 2 comments
Labels
question what do you think? Community feedback requested

Comments

@alxndrsn
Copy link

alxndrsn commented Jul 8, 2019

Occasionally poor configuration leads to double-slashes in URL paths, e.g. http://my-server//some-endpoint

If /some-endpoint maps to a controller, sails will still return 404 Not Found for //some-endpoint. Is there a setting to allow sails to route //some-endpoint to /some-endpoint without creating individual routes for every possible route with extra slashes?

@sailsbot
Copy link

sailsbot commented Jul 8, 2019

@alxndrsn Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@johnabrams7
Copy link
Contributor

johnabrams7 commented Jul 11, 2019

@alxndrsn - Definitely a good point and I see a lot more sites supporting double-slashes (converted to single) these days. I'm not entirely sure of an official way to enable automatic double to single slash routing in Sails, but I will do some digging for potential workarounds. I'll also bring this up with the team for consideration. Could instantly reduce the odds of a 404 from typos / poor config 🎉 Instant UX boost 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question what do you think? Community feedback requested
Development

No branches or pull requests

4 participants