-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect-pg-simple takes 10s to shutdown #6817
Comments
@alxndrsn Thanks for posting! We'll take a look as soon as possible. In the mean time, there are a few ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
It seems you can work around this by manually destroying the session postgresql pool, using In the example project, this can be done by changing const sails = require('sails');
before(done => {
sails.lift({}, err => {
if (err) { return done(err); }
return done();
});
});
after(done => {
sails.lower(() => {
sails.config.session.store.close();
done();
});
}); |
@alxndrsn Thanks for exploring this shutdown delay with repro steps and a workaround. At the moment, our primary adapter in development sails-sql will improve upon sails-postgresql so this will be considered among development plans. Any further input of related applications / experiences from the community are welcome. |
@johnabrams7 I'd be interested to hear what |
@alxndrsn - So far, Postgres support in sails-sql won't be entirely different from the sails-postgresql adapter to start and will require Node v8+. |
This also prevents Again this can be worked around by calling // Start server
sails.lift(rc('sails'), err => {
if(err) {
console.error('Failed to lift app:', err);
try {
sails.config.session.store.close();
} catch(err2) {
console.error('Error caught trying to shut down postgres session store:', err2);
}
return;
}
sails.log.verbose('App lifted successfully.');
}); |
@alxndrsn Appreciate the update & workaround! Will get this documented in the postgresql development notes. |
@johnabrams7 would it be suitable to add the following to
If so, any pointers where would be a suitable place to put this? |
@alxndrsn Actually, sorry just realized |
@johnabrams7 is there a way to add a |
@alxndrsn Yes, you could override the session hook by creating api/hooks/session/ and copying what’s in sails core + modifying the teardown function. |
Node version: 10.16.0
Sails version (sails): 1.2.3
ORM hook version (sails-hook-orm):
DB adapter & version (e.g. sails-mysql@5.55.5): sails-postgresql 1.0.2
connect-pg-simple
takes 10s to shutdown at the end of tests.Example project at: https://github.com/alxndrsn/sailsjs-connect-pg-simple-shutdown-delay
To recreate:
The text was updated successfully, but these errors were encountered: