Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant' connect with socket.io #6835

Open
jannomeister opened this issue Aug 8, 2019 · 7 comments
Open

Cant' connect with socket.io #6835

jannomeister opened this issue Aug 8, 2019 · 7 comments
Labels
repro please Could you reproduce this in a repository for us? sockets Relates to sails.sockets.* or resourceful pubsub (RPS) methods, sails.io.js, or sockets in general

Comments

@jannomeister
Copy link

Node version: 10.15.3
Sails version (sails): 1.0.2
ORM hook version (sails-hook-orm): 2.0.0-16
Sockets hook version (sails-hook-sockets): ^1.4.0
Grunt hook version (sails-hook-grunt): ^3.0.2


I run two server one using sails.js v1 (port=1337) and plain express (port=3001). I'm using nativescript app (mobile) and when I connect using this url http://localhost:3001 (plain express), My application connected successfully but when I changed the url to http://localhost:1337 (my sailsjs server), My app didnt connect :( But the server detects it in beforeConnect. Is there any mistakes im doing?

@sailsbot
Copy link

sailsbot commented Aug 8, 2019

@jannomeister Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@jannomeister
Copy link
Author

jannomeister commented Aug 8, 2019

UPDATE: I updated my sails to the latest 1.2.3 hoping my it will solve the issue, but it doesn't.

@johnabrams7 johnabrams7 added the sockets Relates to sails.sockets.* or resourceful pubsub (RPS) methods, sails.io.js, or sockets in general label Aug 8, 2019
@navicstein
Copy link

Are you using sails.io.js-dist or socket.io-client for sails? 🥇

@jannomeister
Copy link
Author

jannomeister commented Aug 12, 2019

@navicstein on the client I used socket.io-client-swift for iOS and socket.io-client for Android. And for sails.js I used raw socket.io functions to emit data to the client.

If I'm not mistaken, the default namespace for socket.io server is the base url itself http://localhost:1337, right? because when I try it with a simple express server it works perfectly. But when I tried it on sails.js it's not connecting.

PS: my app is not tied up with the server because it's a mobile application (iOS/Android)

@jannomeister
Copy link
Author

is it still not enough?

@hansiemithun
Copy link

@johnabrams7
Copy link
Contributor

@jannomeister @hansiemithun Sails has its own version protocol on top of socket.io protocol that provides added functionality like virtual requests, etc. When using other socket.io clients, you have to make sure you reimplement the sails.io client on top. Does anyone have a minimal repo of their client side socket.io code they can share in a new sails app that reproduces this issue? Thanks, that will help us take a closer look.

@johnabrams7 johnabrams7 added the repro please Could you reproduce this in a repository for us? label Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repro please Could you reproduce this in a repository for us? sockets Relates to sails.sockets.* or resourceful pubsub (RPS) methods, sails.io.js, or sockets in general
Development

No branches or pull requests

5 participants