passwordResetToken, emailProofToken case-insensitive

[danhstevens]

Node version: v12.13.1
Sails version (sails): 1.2.3
ORM hook version (sails-hook-orm): 2.1.1
Sockets hook version (sails-hook-sockets): 2.0.0
Organics hook version (sails-hook-organics): 0.16.
Grunt hook version (sails-hook-grunt): 4.0.0
Uploads hook version (sails-hook-uploads): N/A
DB adapter & version (e.g. sails-mysql@5.55.5): sails-mysql@1.0.1
Skipper adapter & version (e.g. skipper-s3@5.55.5): N/A

---

Generated passwordResetToken and emailProofToken are not case-sensitive which significantly decreases their security.

Steps to reproduce: Generate a password reset email, or account confirmation email. Copy/paste the link. Change the case of any of the letters in the token. The token will still work despite it not being an actual string match.

[sailsbot]

@danhstevens Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[nahanil]

This is database-dependent and briefly mentioned in the Models documentation.

MySQL will use a database collation that is case insensitive by default

I haven't seen any issues like this using PostgreSQL; no idea about Mongo or others.

Maybe add another 'userland' check in api/controllers/entrance/update-password-and-login.js and api/controllers/entrance/confirm-email.js to see whether a token is (really really) valid?

// Look up the user with this reset token.
var userRecord = await User.findOne({ passwordResetToken: inputs.token });

// If no such user exists, or their token is expired, bail.
if (!userRecord || userRecord.passwordResetToken !== inputs.token || userRecord.passwordResetTokenExpiresAt <= Date.now()) {
                // ^ 'ere
  throw 'invalidToken';
}

¯\(ツ)/¯