Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action2 not fully working with typescript #7047

Open
LouAdrien opened this issue Oct 6, 2020 · 2 comments
Open

Action2 not fully working with typescript #7047

LouAdrien opened this issue Oct 6, 2020 · 2 comments
Labels
repro please Could you reproduce this in a repository for us?

Comments

@LouAdrien
Copy link

Node version: v12.14.1
Sails version (sails): 1.2.3
ORM hook version (sails-hook-orm): 2.1.1
Organics hook version (sails-hook-organics): 0.16.0
Grunt hook version (sails-hook-grunt):
DB adapter & version: sails-mong@1.0.1


Hi, I know Typescript is not officially supported by sails, but I am running it on typescript for a while and everything seems to be working fine except this : everything that is supposed to work "under the hood" for actions, like auto mapping of custom exists types, error handling, etc is not working. However, using the normal exits success/error handlers behave as excepted

To be able to use typescript, the only thing I am doing is using
require('ts-node/register');

Before

sails = require('sails');

It's a bit sad as appart from that, everything works in TS. IMO it could be a big plus to advertise full typescript support as this is increasingly becoming a strong requirement for node framework. Happy to help reproducing

Regards,

@sailsbot
Copy link

sailsbot commented Oct 6, 2020

@LouAdrien Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@eashaw
Copy link
Member

eashaw commented Oct 7, 2020

Hi @LouAdrien, can you create a minimal sails repo to help us reproduce this so we can look at this issue more?

@eashaw eashaw added the repro please Could you reproduce this in a repository for us? label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repro please Could you reproduce this in a repository for us?
Development

No branches or pull requests

3 participants