New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type definitions #7110
Comments
@JohnGrisham Thanks for posting! We'll take a look as soon as possible. In the mean time, there are a few ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
@JohnGrisham If you think you'll have the bandwidth to look after the bindings, then it'd be great to have support for Sails added externally in the DefinitivelyTyped repo. I don't use TypeScript myself for now, but since the bindings can live externally to the Sails repo, and there will be an active user of TypeScript maintaining them, I think this sounds awesome! |
Thanks for the feedback! I was hoping to also get some feedback from the community but I haven't seen much of a desire to use Typescript with Sails. I may circle back to this when I have time or if interest does arise. I just ask that this issue be left up if nothing else but to track interest. |
+1 for adding TypeScript definitions. I'm new to TS myself but enjoy the stability it provides to my code. I can't promise anything but I will try to contribute to any efforts you make @JohnGrisham. This could be an alright starting point (but think it predates v1.0): https://github.com/effervescentia/typed-sails |
+1 for this, i moved to express with typeORM + joi for some clients projects and this would be an awesome upgrade for the community to make sails more pluggable |
Some types i used https://gist.github.com/joeherold/cf10ee8a11e145519a7ff960b3ac96a7, credits to @joeherold |
@mrtnzagustin did |
+1 |
+1 It would be great to have Typings support for Sails! |
I will be starting my work to create a definition file. |
@sayami007 I don't think I have time to help out but feel free to add me as a reviewer. |
@JohnGrisham Yes sure. |
This is just an issue to track interest in type definitions for the framework.
If there is enough interest I will consider working on adding definitions as I have time. With the consent of the maintainers, this can be directly in the repo or if a separation is more desirable they can just be added to the Definitely Typed library.
https://github.com/DefinitelyTyped/DefinitelyTyped
Please let me know if this interests you by giving the thumbs up here.
I would also love some feedback from @mikermcneil
The text was updated successfully, but these errors were encountered: