Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asusctl 4.x support #5

Closed
brawas opened this issue Sep 29, 2021 · 2 comments
Closed

asusctl 4.x support #5

brawas opened this issue Sep 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@brawas
Copy link

brawas commented Sep 29, 2021

asusctltray wont start after recently update of asusctl

➜  ~ asusctltray
Traceback (most recent call last):
  File "/usr/local/bin/asusctltray", line 224, in <module>
    TrayIcon()
  File "/usr/local/bin/asusctltray", line 64, in __init__
    self.presets = self.config["power_profiles"].keys()
KeyError: 'power_profiles'

➜  ~ asusctl --version
App and daemon versions:
      asusctl v4.0.3
        asusd v4.0.3

Component crate versions:
    rog-anime v1.1.0
     rog-aura v1.1.0
     rog-dbus v4.0.2
 rog-profiles v1.1.2
rog-supported v4.0.0
  supergfxctl v2.0.0

Product family: ROG Zephyrus G14
Board name: GA401QM

have you any plans to update?

@Baldomo
Copy link
Owner

Baldomo commented Sep 29, 2021

The current situation with asusctl is quite prone to changing (and I had a discussion with asusctl's developer on the Discord about the 4.x release). Many breaking changes were made both to the dbus interfaces and the configuration files (they're now in a TOML-like format instead of JSON), but I'm working on several fixes which I want to push a single commit, so for now asusctltray is completely broken. Said fixes are not trivial at all and will take some time and considerable code refactoring, but I'm positive I can manage. I've already fixed the dbus interfacing code and I'm currently tackling reading the configuration files as the python standard library does not support such a file format. And thank you for opening an issue, this will stay open and pinned as long as this project is in a broken state (or at least asusctl gets a stable 4.x API)

PS: my plans include adding a way to toggle turbo boost on demand, which was removed from asusctl in this latest release

@Baldomo Baldomo self-assigned this Sep 29, 2021
@Baldomo Baldomo added bug Something isn't working good first issue Good for newcomers labels Sep 29, 2021
@Baldomo Baldomo pinned this issue Sep 29, 2021
@Baldomo Baldomo changed the title asusctltray wont start after asusctl update asusctl 4.x support Sep 29, 2021
@Baldomo
Copy link
Owner

Baldomo commented Sep 30, 2021

Implemented everything in dcffa98. If more functionality is required or asusctl 4.1.x comes out and something breaks, this issue will be reopened.

@Baldomo Baldomo closed this as completed Sep 30, 2021
@Baldomo Baldomo unpinned this issue Nov 5, 2021
@Baldomo Baldomo pinned this issue Nov 5, 2021
@Baldomo Baldomo unpinned this issue Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants