Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation - When naming network boxes for props, if there are spaces in the name, the props will not load. #18

Closed
Stikyhooves opened this issue Dec 8, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Stikyhooves
Copy link

Not a real issue, just an observation of an idiosyncrasy that may be worth noting in the comments of the default terrain setup. When naming network boxes for props, if there are spaces in the name, the props will not load. This can be replicated by renaming a prop network box to have a space rather than underscore, correcting the node reference, and refreshing the biome.

Replacing spaces in the name with underscores (as god intended for all naming conventions) resolves this issue. Took me a while to figure this out because I usually favor underscores.

-Oz

NamingFail_01
NamingFail_02

@Baldrax Baldrax self-assigned this Dec 10, 2022
@Baldrax Baldrax added the bug Something isn't working label Dec 10, 2022
@Baldrax
Copy link
Owner

Baldrax commented Dec 10, 2022

Yes, I am aware of this but thanks for bringing it up to remind me to see if I can resolve that or at least put up a warning about it.
In the Forest_Gully example file I made a note about it (typos and all), but there is a lot of info in that file to take in and I'm not sure if everyone goes through it all.
image

I have a feeling I may be able to figure out how to get it to work with spaces, I'm not exactly sure why it doesn't, but I haven't looked at that code in a while.

@Stikyhooves
Copy link
Author

Rgr that. I just have the base version. The only note that shows when adding a new terrain node is much lighter:
CurrentText

@Baldrax
Copy link
Owner

Baldrax commented Dec 10, 2022

Yeah, the example_Forest_Gully file has way more notes and guides you through the entire terrain process, it is worth a browse through.

That said, I found the root of the problem and a fix should go out in the next version:

There is a function to isolate the group of items to be selected on some of the Houdini nodes:
@name==`chs("../tile_set_1x1")`

It needed to be protected by quotes to preserve the entire name with spaces:
@name=="`chs("../tile_set_1x1")`"

It is in a few places in the Tiler and the Scatter nodes so I'll fix it, test it out then add it to the next release.

@Stikyhooves
Copy link
Author

I'll have to dig around and find that. :) - Thanks.

@Baldrax
Copy link
Owner

Baldrax commented Dec 10, 2022

It is in the directory for the toolset, under hip/examples/...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants