Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are url_path really needed currently? #39

Closed
dmanners opened this issue Sep 12, 2022 · 2 comments
Closed

Are url_path really needed currently? #39

dmanners opened this issue Sep 12, 2022 · 2 comments

Comments

@dmanners
Copy link

dmanners commented Sep 12, 2022

This is more a question than an issue so sorry if this is the wrong place to ask such questions.

As far as I know url_path is now deprecated in newer versions of Magento 2. My question here is would it make sense to only flag these errors on older version of Magento or if you are not supporting older versions could it simply be removed?

See magento/magento2#9113 (comment)

@hostep
Copy link
Member

hostep commented Sep 12, 2022

Hey David

You are talking about products, right? In that case the url_path has always been deprecated in all Magento 2 versions (not only newer versions). For categories, they are still valid.

As far as I know, for products they are still being used when filled in in the database for generating url rewrites which can lead to all kinds of bad things because it's a hidden field that's not exposed in the UI, so changing the url_key field of a product will result in no change since the hidden url_path will overwrite it.

So I think we should still warn about them if they are being detected in the database. You'd best remove them all in case they are still used in the database for products.

@dmanners
Copy link
Author

Hi,

Thanks for the information. Yes I was not sure if it was just products or not but it seems they still get used for rewrites so probably best to keep it all active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants