Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process the image if they try to preload a zip/gzip archive (except for Edison) #156

Open
zvin opened this issue Feb 5, 2018 · 5 comments
Open

Process the image if they try to preload a zip/gzip archive (except for Edison) #156

zvin opened this issue Feb 5, 2018 · 5 comments

Comments

@zvin
Copy link
Contributor

zvin commented Feb 5, 2018

No description provided.

@zvin zvin self-assigned this Feb 5, 2018
@lekkas
Copy link

lekkas commented Aug 8, 2018

Bumping this up, since it came up again in support recently

@pdcastro
Copy link
Contributor

pdcastro commented May 15, 2020 •
edited
Loading

A related CLI issue was created, as the user didn't unzip the image: sfdisk: /img/balena.img: does not contain a recognized partition table.

Even better than warning the user, the best UX would probably be to accept the zip file, and automatically unzip it if necessary.

@pdcastro pdcastro mentioned this issue May 17, 2020
Merged
@vipulgupta2048
Copy link
Member

vipulgupta2048 commented Jul 25, 2021 •
edited
Loading

I will take that, maybe we could add gzip support as well to preload
I wonder what was the issue with Edison images was (That platform has gone quite old)

@vipulgupta2048 vipulgupta2048 changed the title Warn the user if he tries to preload a zip archive (except for Edison) Process the image if they try to preload a zip/gzip archive (except for Edison) Jul 25, 2021
@vipulgupta2048
Copy link
Member

vipulgupta2048 commented Jul 25, 2021 •
edited
Loading

I am seeing code that handles zip archives and edison archives especially. So I tried it and it hasn't worked for the past 30 minutes from this point onwards. It's stuck at this one, will continue the investigation.

Screenshot from 2021-07-26 01-18-37

@klutchell
Copy link
Contributor

Run it in debug mode and see where it's getting stuck? What version of the CLI are you running because I fixed that recently to present a warning?

@zvin zvin removed their assignment Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zvin @lekkas @pdcastro @klutchell @vipulgupta2048