Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

Update API calls from V1 endpoints #28

Closed
phil-d-wilson opened this issue Jul 12, 2021 · 8 comments · Fixed by #31
Closed

Update API calls from V1 endpoints #28

phil-d-wilson opened this issue Jul 12, 2021 · 8 comments · Fixed by #31

Comments

@phil-d-wilson
Copy link
Collaborator

Either move to the latest endpoint, or since we are already bringing in the SDK into the block, change to using that instead

Opinion @Bucknalla ?

@Bucknalla
Copy link
Contributor

@phil-d-wilson yeah I think we just standardise using the SDK if we're already using it

@jellyfish-bot
Copy link

[pipex] This issue has attached support thread https://jel.ly.fish/1797dc8b-0c41-48fb-8c5d-044e523da720

@Bucknalla
Copy link
Contributor

@phil-d-wilson I was talking with Carlo and he's been actually working in the background to fix this for some of the QA work he's been doing for the Fin so he will be pushing a branch shortly that addresses a bunch of things. It should also be ES6 compliant so it'll be super easy to take what I started working on for the TS rewrite and apply that as well.

@phil-d-wilson
Copy link
Collaborator Author

Sounds great @Bucknalla ! I'm happy to contribute to the TS work.

@curcuz
Copy link
Contributor

curcuz commented Jul 27, 2021

@phil-d-wilson @Bucknalla WIP PR here #29

@jellyfish-bot
Copy link

[thgreasi] This issue has attached support thread https://jel.ly.fish/c9241ba0-abff-453b-892c-e50a3d84c5c3

@mehalter
Copy link

@phil-d-wilson @Bucknalla was this resolved with #31 since that took place of #29 in a reorganization?

@curcuz
Copy link
Contributor

curcuz commented Aug 17, 2021

@mehalter yes!

@kb2ma kb2ma linked a pull request Aug 17, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants