Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH keys configured in config.sh file are added to config.json, do not replace it #8

Open
etcetc opened this issue May 20, 2020 · 2 comments

Comments

@etcetc
Copy link

etcetc commented May 20, 2020

Currently, the update script explicitly adds any new keys specified in the config.sh file to the os.sshKeys entry of config.json. While it seems this is the desired behavior, it has undesirable effects.

  1. It becomes very difficult to keep a reference config.sh for the group of field devices
  2. It becomes very difficult to deprecate and replace ssh keys

To reproduce issue:

  1. check the config.json file on the target device. Check that the value for key os.sshKeys is empty.
  2. Add an ssh key in config.sh script, e.g.
    SSHKEYS=("ssh-rsa AAAA ..... testKey")
  3. Configure the key for the test unit in batch
  4. run the run.sh script.
  5. View the config.json file on the target device. It will now include the specified key
  6. Change the key in config.sh
  7. Remove config.log and run run.sh again
  8. View the config.json file on the target device. It will now include two copies of the specified key
@jellyfish-bot
Copy link

[saintaardvark] This issue has attached support thread https://jel.ly.fish/#/728a48e0-84fa-4209-9509-88f613cbafd2

@etcetc
Copy link
Author

etcetc commented Jun 12, 2020

issue addressed in https://github.com/etcetc/configizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants