Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a fixed name for balena-engine healthcheck container #2256

Closed
klutchell opened this issue Jul 15, 2021 · 2 comments · Fixed by #2296
Closed

Consider a fixed name for balena-engine healthcheck container #2256

klutchell opened this issue Jul 15, 2021 · 2 comments · Fixed by #2296

Comments

@klutchell
Copy link
Collaborator

This avoids a history of auto-named containers for anyone monitoring the socket.

The container is removed immediately either way, so no harm in assigning a fixed name as long as we check for conflicts before running again.
@jellyfish-bot
Copy link

[klutchell] This issue has attached support thread https://jel.ly.fish/2385c756-2322-4b1b-b879-6e77221e5ece

@st-mono
Copy link

st-mono commented Jul 20, 2021

A fixed name would make the container's purpose is clearer, in addition to reducing the clutter of entries/cardinality in any database logging system metrics.

@klutchell klutchell mentioned this issue Aug 19, 2021
Merged
6 tasks
@ghost ghost closed this as completed in #2296 Aug 31, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assign a fixed name to the balena-healthcheck container balena-os/meta-balena
3 participants
@klutchell @jellyfish-bot @st-mono