Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textfield hotspot #18

Closed
leibale opened this issue Oct 4, 2020 · 5 comments
Closed

textfield hotspot #18

leibale opened this issue Oct 4, 2020 · 5 comments

Comments

@leibale
Copy link

leibale commented Oct 4, 2020

Hi,

The hotspot for the "native elements" (input, textarea) is smaller than div.mdc-text-field (see the image below).
I'm actually not sure if it caused by balm-ui or material-components-web..

input-hotspot

@elf-mouse
Copy link
Member

elf-mouse commented Oct 7, 2020

Yes, It's the default rendering by MDC.

And you can overwrite css by sass var $input-height

BalmUI 9.x Docs next-material.balmjs.com for Vue 3.0

@leibale
Copy link
Author

leibale commented Oct 7, 2020

In the interactive demo of the text fields in the official material design site, it renders the input on the whole space, and I assume that this should/is the default behavior... Correct me if I'm wrong...

@leibale
Copy link
Author

leibale commented Oct 7, 2020

Also, this code

@use '~balm-ui/components/textfield' as textfield-variables with (
  $input-height: 100%
);

throws "Can't find stylesheet to import." error.

(and prob there is no configuration error cause I have some variables set on form-field and it dose works, so...)

@elf-mouse
Copy link
Member

In the interactive demo of the text fields in the official material design site, it renders the input on the whole space, and I assume that this should/is the default behavior... Correct me if I'm wrong...

Because material.io uses the material-components-web@5.x,
and material.balmjs.com/next-material.balmjs.com uses the material-components-web@8.x (canary version)

@elf-mouse
Copy link
Member

elf-mouse commented Oct 8, 2020

Also, this code

@use '~balm-ui/components/textfield' as textfield-variables with (
  $input-height: 100%
);

throws "Can't find stylesheet to import." error.

(and prob there is no configuration error cause I have some variables set on form-field and it dose works, so...)

See BalmUI Textfield Component Docs for details

Dark Sass Usage:

  • for balm-ui >= 8

    @use '@material/textfield' as textfield-variables with (
      $input-height: 100%
    );
  • for balm-ui >= 6 and balm-ui < 8

    @use '@material/textfield/variables' as textfield-variables with (
      $input-height: 100%
    );

balm-ui < 6: no $input-height variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants