Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify role model - remove person and company from payment #31

Closed
frank-baier opened this issue Jun 4, 2019 · 2 comments · Fixed by #34
Closed

Simplify role model - remove person and company from payment #31

frank-baier opened this issue Jun 4, 2019 · 2 comments · Fixed by #34
Assignees
@MarkusTiede

Comments

@frank-baier
Copy link
Contributor

frank-baier commented Jun 4, 2019 •
edited by MarkusTiede
Loading

Due to an evolvement in business requirements we would like to remove Person and Company from the Payment entity.

As by this change the Payment entity now only will consist of one field, we propose to remove the entire payment entity and to pull up the paymentCode to Contract level.
@MarkusTiede MarkusTiede changed the title Simplify Role Model - Remove person and company from payment Simplify role model - remove person and company from payment Jun 4, 2019
@rolandsusans
Copy link

Yeah sure - works for us.
( When all these micro changes are done will be nice to see new sample payload ).

@MarkusTiede MarkusTiede self-assigned this Jun 4, 2019
@MarkusTiede MarkusTiede mentioned this issue Jun 4, 2019
Merged
@MarkusTiede
Copy link
Member

Thank @rolandsusans for noticing: I've filed #41 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkusTiede MarkusTiede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alter and simplify entities / role model baloise/corellia
3 participants
@MarkusTiede @frank-baier @rolandsusans