Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is is still maintained ? Open to pull requests ? #184

Open
vricosti opened this issue May 3, 2024 · 4 comments
Open

Is is still maintained ? Open to pull requests ? #184

vricosti opened this issue May 3, 2024 · 4 comments

Comments

@vricosti
Copy link
Contributor

vricosti commented May 3, 2024

Hi,
Is it still maintained ? If yes I will propose some pull requests (start by updating example to recent react native version) and if not I will for it and create my own version.
Thanks

@vricosti vricosti changed the title Still maintained Is is still maintained ? Open to pull requests ? May 3, 2024
@balthazar
Copy link
Owner

Feel free to PR

@balthazar
Copy link
Owner

Is it just to update docs, or do you have plans for more features / improvements?

@vricosti
Copy link
Contributor Author

vricosti commented May 3, 2024

I will only first try to test the example, then test it on my iPhone/android and if everything works I am not sure to add improvments except if you have some ideas.
Update: when we create project with recent version of react-native, project are using typescript so an improvment would be to provide types.

@vricosti
Copy link
Contributor Author

vricosti commented May 5, 2024

I did a PR for a branch dev/update-example.
I have also a branch where I rewrote in typescript but I think EventEmitter has changed because I have some missing definitions and crash espacially with .on(....).
The branch is called dev/use-typescript, I will try to understand what is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants