You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When scanning the second plant on the same planet EDMC works as intended with the exception to not adding the entry to the notyetsolddata.json.
This then shows in the "Scans in this system" section of the plugin where the recently finished scan does not show up.
(not sure if same planet is relevant, Not sure if a third scan would work again)
Specifically the code that it should run but does not for some reason is:
ifcurrententrytowritenotinplugin.notyetsolddata[cmdr]:
# If there is no second Sample scantype event# we have to save the data here.plugin.notyetsolddata[cmdr].append(currententrytowrite)
file=plugin.AST_DIR+"\\notsoldbiodata.json"withopen(file, "r+", encoding="utf8") asf:
notsolddata=json.load(f)
ifcmdrnotinnotsolddata.keys():
notsolddata[cmdr] = []
notsolddata[cmdr].append(currententrytowrite)
f.seek(0)
json.dump(notsolddata, f, indent=4)
f.truncate()
currententrytowrite= {}
located at line 83 within bioscan_event() in eventhandling.py
To Reproduce
Steps to reproduce the behavior:
Start EDMC with plugin
Do the first full scan of any Exobiology on a planet.
Do a second full scan of any Exobiology on that same planet.
See error
Expected behavior
the plugin should add the entry of the exobiology scan immediately to the notyetsolddata.json and diplay the finished but unsold scan below the "Scans in this system" line.
Screenshots
Compare what the line "Last Exobiology Scan" says with both the current system and body and see that an entry is missing below the "Scans in this system" line.
Desktop (please complete the following information):
OS: Windows 11
AST Version: dev 0.2.7
EDMC Version: 5.8.1+d81c93c
Additional Context
I can remedy this locally by using the journal crawling function in the settings though it is not great to wait up to a minute after every second scan
The text was updated successfully, but these errors were encountered:
Also ensuring we ask Canonn upon the first event we know the system that we're in. (otherwise we just don't know how how many plants are in on a planet in that system)
Closes#53
Problem was I did not shallow copy the object into the set that I was testing against so it always was the same in the set of unsolddata and the most current entry.
Also ensuring we ask Canonn upon the first event we know the system that we're in. (otherwise we just don't know how how many plants are in on a planet in that system)
Closes#53
Describe the bug
When scanning the second plant on the same planet EDMC works as intended with the exception to not adding the entry to the notyetsolddata.json.
This then shows in the "Scans in this system" section of the plugin where the recently finished scan does not show up.
(not sure if same planet is relevant, Not sure if a third scan would work again)
Specifically the code that it should run but does not for some reason is:
located at line 83 within bioscan_event() in eventhandling.py
To Reproduce
Steps to reproduce the behavior:
Expected behavior
the plugin should add the entry of the exobiology scan immediately to the notyetsolddata.json and diplay the finished but unsold scan below the "Scans in this system" line.
Screenshots
![Optional title Image](https://camo.githubusercontent.com/32d07a71bb63d0cc9efa7afee2ee4e16e0aa6499b9a171492910cbf5277ee210/68747470733a2f2f692e6779617a6f2e636f6d2f61333037336230363162396133343364663330333832613962366561613838372e706e67)
Compare what the line "Last Exobiology Scan" says with both the current system and body and see that an entry is missing below the "Scans in this system" line.
Desktop (please complete the following information):
Additional Context
I can remedy this locally by using the journal crawling function in the settings though it is not great to wait up to a minute after every second scan
The text was updated successfully, but these errors were encountered: