Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid create a MaterialRippleLayout when the view parent already is one #5

Closed
joaogouveia opened this issue Oct 8, 2014 · 3 comments

Comments

@joaogouveia
Copy link

Hi balysv, it's me again.

This is a suggestion. Check if view parent already is a MaterialRiplleLayout before create a new one, to prevent stackoverflow.
I got this error in an adapter that I create the ripple on my code. But, as an adapter reuse the view, my code insert an MaterialRippleLayout inside another and this cause stackoverflow.
I fix the issue in my code, but I suggest this fix on the create method.

Thanks

@balysv
Copy link
Owner

balysv commented Oct 8, 2014

Sounds reasonable. Can you make a PR?

@joaogouveia
Copy link
Author

sure

@joaogouveia
Copy link
Author

sorry for the delay. I've created the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants