fix(measure): UI buttons unresponsive/streamline socket URL handling #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flashlight-docs canceled.
|
Flashlight Automated Report 🔦 |
Seemingly Jest can fail even though tsc is passing properly Since we catch errors in "yarn tsc" already, we don't need jest to bother us about it anyway I think ts-jest doesn't recognize properly the .d.ts definition basically
Flashlight Automated Report 🔦 |
Almouro
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #186 addressing this issue comment.
The issue was caused by the webapp connecting to a fixed socket server url (
http://localhost:3000). To resolve this, we server-side render data into a (__FLASHLIGHT_DATA__) object, which is now available in the window context of the webapp. This change enables the webapp's socket client to connect to a dynamic server url.A notable aspect of this change is its impact on unit testing, particularly for the
MeasureWebAppcomponent. Related tests now require setting up thewindow.__FLASHLIGHT_DATA__context before importingMeasureWebApp. This is crucial because ifwindow.__FLASHLIGHT_DATA__.serverSocketUrlis not initialized correctly, the webapp's socket connection will fail, leading to test failures that may not be immediately apparent. While this adds a layer of complexity to the initial testing approach, it's a necessary trade-off for the enhanced dynamism in the socket server connections.#189