fix(fastlane-env): remove minimum_codepush_version

bamlab · Feb 9, 2019 · 527482c · 527482c
1 parent 98e4790
commit 527482c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/generators/fastlane-setup/templates/env b/generators/fastlane-setup/templates/env
@@ -14,5 +14,3 @@ IOS_VERSION='1.0.0'
 ANDROID_VERSION_NAME='1.0.0'
 IOS_VERSION_BUILD_NUMBER='1000000'
 ANDROID_VERSION_CODE='1000000'
-IOS_MINIMUM_CODEPUSH_VERSION='1.0.0'
-ANDROID_MINIMUM_CODEPUSH_VERSION='1.0.0'
diff --git a/generators/fastlane-setup/templates/fastlane/Fastfile b/generators/fastlane-setup/templates/fastlane/Fastfile
@@ -150,7 +150,7 @@ platform :ios do
     set_js_env
     if options[:codepush] then
       release_notes = %x[#{release_notes_command}]
-      sh "cd .. && appcenter codepush release-react -d #{ENV['IOS_CODEPUSH_DEPLOYMENT_NAME']} -a #{ENV['APPCENTER_USERNAME']}/#{ENV['IOS_APPCENTER_APP_ID']} --target-binary-version \">=#{ENV['IOS_MINIMUM_CODEPUSH_VERSION']}\" --description \"#{release_notes}\" --disable-duplicate-release-error"
+      sh "cd .. && appcenter codepush release-react -d #{ENV['IOS_CODEPUSH_DEPLOYMENT_NAME']} -a #{ENV['APPCENTER_USERNAME']}/#{ENV['IOS_APPCENTER_APP_ID']} --target-binary-version \"#{ENV['IOS_VERSION']}\" --description \"#{release_notes}\" --disable-duplicate-release-error"
     else
       match(
         shallow_clone: true,
@@ -261,7 +261,7 @@ platform :android do
     set_js_env
     if options[:codepush] then
       release_notes = %x[#{release_notes_command}]
-      sh "cd .. && appcenter codepush release-react -d #{ENV['ANDROID_CODEPUSH_DEPLOYMENT_NAME']} -a #{ENV['APPCENTER_USERNAME']}/#{ENV['ANDROID_APPCENTER_APP_ID']} --target-binary-version \">=#{ENV['ANDROID_MINIMUM_CODEPUSH_VERSION']}\" --description \"#{release_notes}\" --disable-duplicate-release-error"
+      sh "cd .. && appcenter codepush release-react -d #{ENV['ANDROID_CODEPUSH_DEPLOYMENT_NAME']} -a #{ENV['APPCENTER_USERNAME']}/#{ENV['ANDROID_APPCENTER_APP_ID']} --target-binary-version \"#{ENV['ANDROID_VERSION_NAME']}\" --description \"#{release_notes}\" --disable-duplicate-release-error"
     else
       build
       if ENV['DEPLOYMENT_PLATFORM'] === 'hockeyapp' then