Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing virtual dtor in failure_formatter #131

Closed
OpatrilPeter opened this issue Nov 25, 2017 · 1 comment
Closed

Missing virtual dtor in failure_formatter #131

OpatrilPeter opened this issue Nov 25, 2017 · 1 comment
Assignees
Labels
bug Approved bug in bandit

Comments

@OpatrilPeter
Copy link

Hello,
compiling with clang++ 6.0 triggers a warning about not having virtual destructor in failure_formatter while also having virtual functions.
Despite the fact that it currently shouldn't result in any bugs, it could lead to obscure problems later once any type inheriting from failure_formatter would contain any data member requiring destructor.
Even aside from that, this is also a problem for all people treating warnings as errors.

Thus, my recommendation is simple addition of following line
virtual void ~failure_formatter() {}

@sbeyer
Copy link
Member

sbeyer commented Nov 25, 2017

Thanks for reporting! I will fix this soon.

@sbeyer sbeyer self-assigned this Nov 25, 2017
@sbeyer sbeyer added the bug Approved bug in bandit label Nov 25, 2017
@sbeyer sbeyer closed this as completed in 3dea8c3 Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Approved bug in bandit
Projects
None yet
Development

No branches or pull requests

2 participants