This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Split up project into separate components + responsibilities #101
Labels
better-engineering
Tech debt or maintainability improvements
Comments
Creating things under https://github.com/bankroll-py |
Started thinking about how to isolate third-party dependencies to as small a region as possible, so I ended up adding a digraph {
rankdir = BT;
{ rank = min; model; }
{ rank = same; ibkr; schwab; fidelity; vanguard; }
{ rank = max; cli, notebooks }
ibkr, schwab, fidelity, vanguard, marketdata -> model
ibkr, schwab, fidelity, vanguard -> "plugin framework" [style=dashed]
ibkr -> marketdata [style=dashed]
ibkr -> ib_insync
marketdata -> rx
rx [style=dotted]
ib_insync [style=dotted]
analysis -> model
analysis -> pandas
pandas [style=dotted]
notebooks -> analysis, "plugin framework", marketdata
cli -> analysis, "plugin framework", marketdata
} |
Not really happy with this generic |
To do:
|
I suppose we can just put all the |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In trying to build another project which wants to use pieces of bankroll, I'm finding the current structure kind of unwieldy, and don't want to risk this becoming a kitchen sink. At bare minimum, we should probably separate the model from the brokerage support from the analysis and tools.
Something like this, although not necessarily as finely-sliced:
The text was updated successfully, but these errors were encountered: