Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MORNING-SESSION-CODE-REVIEW #5

Open
omarsalem7 opened this issue Jan 28, 2022 · 0 comments
Open

MORNING-SESSION-CODE-REVIEW #5

omarsalem7 opened this issue Jan 28, 2022 · 0 comments
Projects
version 0.01

Comments

@omarsalem7
Copy link

omarsalem7 commented Jan 28, 2022 •
edited

Hi @banlon-jones 馃憢, Great work on your project.

Project Highlights 馃憦馃徎

鉁旓笍 No linter errors.
鉁旓笍 You used the correct GitHub Flow.
鉁旓笍 Professional README
鉁旓笍 Good commit messages
鉁旓笍 No console.log() or eval() left in the build

There are a few things that can be modified

  • It would be nice to add a link for a demo for the project in the README.
  • You can work in the future in the project to make it responsive for all screen
  • It will be better if you rename the main.js to another name relevant to the code that exists in it, for example API.js

Feel free, if you have any further explanations
Cheers 馃槃
@banlon-jones banlon-jones added this to To do in version 0.01 Jan 31, 2022
@banlon-jones banlon-jones moved this from To do to In progress in version 0.01 Jan 31, 2022
@banlon-jones banlon-jones moved this from In progress to Done in version 0.01 Jan 31, 2022
@banlon-jones banlon-jones moved this from Done to In progress in version 0.01 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
version 0.01
In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@omarsalem7