Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of unresolved identifier 'gedatsuAssert' #23

Merged
merged 1 commit into from May 12, 2020
Merged

Fix use of unresolved identifier 'gedatsuAssert' #23

merged 1 commit into from May 12, 2020
+6 −3

Conversation

ElonPark
Copy link
Contributor

@ElonPark ElonPark commented May 12, 2020 •
edited

Fix build error when use carthage

/Carthage/Checkouts/Gedatsu/Sources/Gedatsu/Gedatsu.swift:42:9: error: use of unresolved identifier 'gedatsuAssert'
        gedatsuAssert(data != nil)
        ^~~~~~~~~~~~~
/Carthage/Checkouts/Gedatsu/Sources/Gedatsu/Interceptor.swift:21:13: error: use of unresolved identifier 'gedatsuAssert'
            gedatsuAssert(false, "unexpected queue is empty", ignoreWarnLog: true)
            ^~~~~~~~~~~~~
/Carthage/Checkouts/Gedatsu/Sources/Gedatsu/UIViewExtension.swift:15:9: error: use of unresolved identifier 'gedatsuAssert'
        gedatsuAssert(Thread.isMainThread)
        ^~~~~~~~~~~~~
/Carthage/Checkouts/Gedatsu/Sources/Gedatsu/UIViewExtension.swift:16:9: error: use of unresolved identifier 'gedatsuAssert'
        gedatsuAssert(NSClassFromString("NSISEngine") == engine.classForCoder, "Unexpected receive argument for NSEngine")
        ^~~~~~~~~~~~~

** ARCHIVE FAILED **

@ElonPark ElonPark changed the title 🐛 Fix use of unresolved identifier 'gedatsuAssert' Fix use of unresolved identifier 'gedatsuAssert' May 12, 2020
@bannzai bannzai self-requested a review May 12, 2020 13:31
bannzai
bannzai reviewed May 12, 2020
View reviewed changes
Copy link
Owner

@bannzai bannzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅Ah, Nice catch! Thank you!! LGTM

@bannzai bannzai merged commit ee81fbe into bannzai:master May 12, 2020
@ElonPark ElonPark deleted the fix-carthage-build-issue branch May 12, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bannzai bannzai bannzai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ElonPark @bannzai