Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not an issue - question on refactoring node to use upstream ipadapter loader #31

Closed
johndpope opened this issue Jan 25, 2024 · 2 comments

Comments

@johndpope
Copy link

johndpope commented Jan 25, 2024

basically i have 2 repos -
https://github.com/cubiq/ComfyUI_IPAdapter_plus

https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID

they have different/conflicting implementations of ipadapter loader.

you seem to have harmoniously integrated the 2.
https://chat.openai.com/share/ffc06449-798a-4ff5-85e1-94e0810b8bab

ZHO-ZHO-ZHO/ComfyUI-InstantID#49

Chatgpt normally gives me good answers - but maybe the question is not accurate.
do I need to throw the Ipadapter_instantidLoader_Node_Zho in the bin?
but then how to wire up stuff?

I'll keep digging.

background - I do have ipadapter_plus working / and the ComfyUI-InstantID was working before.

@peteromallet
Copy link
Collaborator

Yes, I've heard of Ipadapter_instantidLoader_Node_Zho being problematic - would wait for @cubiq to implement that properly

@johndpope
Copy link
Author

I solved it
ZHO-ZHO-ZHO/ComfyUI-InstantID#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants