Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broad CSS properties messing with CSS frameworks #98

Closed
Alex-Hay opened this issue Oct 23, 2019 · 4 comments
Closed

Broad CSS properties messing with CSS frameworks #98

Alex-Hay opened this issue Oct 23, 2019 · 4 comments

Comments

@Alex-Hay
Copy link

Hi there,

Love what you've done with this, you've made a really great lightbox! One small nit-pick is that those of us using TailwindCSS are running into a few css conflicts (primarily .hidden). It'd be great it some of the targeted css properties could have a narrower scope and preferably load in from an external stylesheet.

Thanks for your hard work!
Alex

@piotrzdziarski
Copy link
Collaborator

Hello,

I'm glad you like it!
Where do you exactly run into conflict with .hidden?

@edwardjosephbennett
Copy link

As TailwindCSS is a utility first framework it contains a class to hide elements by applying .hidden. As your classes are added to the head of the document, this has more specificity than the ones defined by and used in tailwind, causing elements to be hidden on the page.

I've created a merge request with a fix, that hopefully should resolve the issue. Sorry if I've done it wrong or I haven't fixed all issues (I couldn't find any docs on how to submit the fix).

See #104

@sergeyshevch
Copy link

Hi! Thanks for resolving this problem. Can you make release with this fix?

@piotrzdziarski
Copy link
Collaborator

Released new version with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants