Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist regex matches substrings #25

Closed
orymate opened this issue Dec 5, 2018 · 0 comments · Fixed by #26
Closed

Whitelist regex matches substrings #25

orymate opened this issue Dec 5, 2018 · 0 comments · Fixed by #26
Assignees
@orymate @pbalogh-sa

Comments

@orymate
Copy link
Contributor

orymate commented Dec 5, 2018

Substring matching is used on whitelisted image names instead of full-string match.

anchore-image-validator/cmd/handler.go

Line 80 in bf98062

match, err := regexp.Compile(wl.Spec.Regexp)

MatchString reports whether the string s contains any match of the regular expression re.

Should surround with ^(/)$
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orymate orymate

@pbalogh-sa pbalogh-sa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regexp.Compile string surrounding with ^( )$ banzaicloud/anchore-image-validator
2 participants
@orymate @pbalogh-sa