Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow emit_invalid_record_to_error to be set to false #574

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Allow emit_invalid_record_to_error to be set to false #574

merged 2 commits into from
Sep 6, 2020

Conversation

velothump
Copy link
Contributor

Q A
Bug fix? yes
Related tickets Fixes #571
License Apache 2.0

What's in this PR?

Fix to allow emit_invalid_record_to_error to be set to false

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@tarokkk tarokkk requested a review from ahma September 6, 2020 11:36
ahma
ahma approved these changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @velothump

@ahma ahma merged commit 1843db5 into kube-logging:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarokkk tarokkk tarokkk approved these changes

@ahma ahma ahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emit_invalid_record_to_error field not getting set
3 participants
@velothump @tarokkk @ahma