Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging-operator Helm chart option for monitoring.serviceMonitor.enable #580

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Fix logging-operator Helm chart option for monitoring.serviceMonitor.enable #580

merged 1 commit into from
Sep 13, 2020

Conversation

rdpa
Copy link
Contributor

@rdpa rdpa commented Sep 10, 2020 •
edited by ahma

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Fixing case of monitoring.serviceMonitor.enable in the ServiceMonitor manifest

Why?

All documentation says that enable is lowercase, while in the chart it is uppercase

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

ahma
ahma approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rdpa LGTM

@ahma ahma merged commit 4dd331d into kube-logging:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarokkk tarokkk tarokkk approved these changes

@ahma ahma ahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rdpa @CLAassistant @tarokkk @ahma