Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally expose new metrics for AWS Spot Rebalance Recommendations #13

Open
gjtempleton opened this issue Nov 19, 2020 · 4 comments · May be fixed by #15
Open

Optionally expose new metrics for AWS Spot Rebalance Recommendations #13

gjtempleton opened this issue Nov 19, 2020 · 4 comments · May be fixed by #15

Comments

@gjtempleton
Copy link

Is your feature request related to a problem? Please describe.

AWS now provide a new metadata endpoint to (potentially) pre-warn of likely spot interruption on instances. Metrics on these rebalance recommendations along with the time they were generated are likely to be useful for cluster operators.

Describe the solution you'd like to see

The spot termination exporter to (potentially optionally) expose a number of new metrics:

aws_instance_metadata_service_events_available     Metadata service events endpoint available
aws_instance_rebalance_recommended                 Instance rebalance is recommended
aws_instance_rebalance_recommended_at              Unix epoch rebalance recommendation was exposed at

Describe alternatives you've considered

A completely separate component scraping the relevant metadata endpoint (as it differs from the already scraped spot termination endpoint.) However this would result in running another daemonset alongside the existing one.

Additional context

I've already done most of the work to perform this scraping and metrics exposition on an internal fork of the project, happy to raise the PR to add this functionality to the wider project.

@hcbraun
Copy link

hcbraun commented May 27, 2021

@gjtempleton Could you share your work? I need this feature too

@gjtempleton gjtempleton linked a pull request Sep 23, 2021 that will close this issue
3 tasks
@gjtempleton
Copy link
Author

gjtempleton commented Sep 23, 2021

Hey @hcbraun, sorry, I somehow missed your comment before, I've finally raised #15 if you want to use this functionality, but given the seeming lack of activity on this repo here am prepared to maintain my fork at gjtempleton/spot-termination-exporter going forward.

@hcbraun
Copy link

hcbraun commented Sep 24, 2021

Thanks a lot, @gjtempleton !

@gjtempleton
Copy link
Author

@hcbraun Sorry, I realised on finally testing my implementation that I'd left a couple of early returns which would have meant the new metric wouldn't be exposed. I've updated this PR and published a Docker image available as
ghcr.io/gjtempleton/spot-termination-exporter:0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants