[Feature]Druid DataSource timeBetweenConnectErrorMillis Config #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
你好，基于此issues #487 发现目前项目确实缺少关于 druid 的timeBetweenConnectErrorMillis 的配置。
我在本地 dynamic-datasource-samples 项目中实际添加属性测试后，初始化后的 DruidDataSource 的 timeBetweenConnectErrorMillis 依旧采用了默认值 500，故提了此pull Request。
另外，我觉得后续需要实时补齐各类DataSource 的配置实属不是一件简单的事情，会考虑继承各类DataSource的配置这种方式，从而后续只需要更新 DataSource 的版本么？
期待你的回复。