REQUIRED主事务内多个NESTED次事务不提交事务bug #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZPZP1 look look |
|
|
|
正常嵌套事务每层都有一个savepointHolder，正常某层(方法)释放会释放掉整层的savepoint，都释放后会将整层的savepointHolder从集合中清除掉。 |
|
所以到底有没有问题啊~ |
|
有问题,最后主事务不会提交,而是判断仍然有savepoint,等下我截图 |
|
最后主事务执行,判断仍然有hasSavePoint为true,走释放,但是最后不走提交事务 |
|
嗯嗯，REQUIRED模式下会有这个问题，把这个判断加上吧，相当于把整体事务传播改为nested了。 |
|
|
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
The description of the PR:
https://github.com/dynamic-datasource/dynamic-datasource-samples.git
示例代码中,代码内两个service添加事务
@ds("product")
@DSTransactional(propagation = DsPropagation.NESTED)
导致最后主事务判断出错仍不提交事务
并且tx不关闭,下次进入锁死
Other information: