Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isDirty() after retrieving models #51

Closed
zoul0813 opened this issue Jun 15, 2017 · 3 comments
Closed

isDirty() after retrieving models #51

zoul0813 opened this issue Jun 15, 2017 · 3 comments

Comments

@zoul0813
Copy link
Contributor

Models appear to be dirty after retrieving them.

When using a standard Eloquent model, isDirty() returns false after retrieving it ...however, DynamoDbModel instances appear to be dirty after retrieving them which makes it hard to tell whether or not the model is actually dirty.
@baopham
Copy link
Owner

baopham commented Jun 15, 2017

Ah yeah, I didn't consider isDirty. Nice catch.

@zoul0813
Copy link
Contributor Author

I believe this one is as simple as calling $model->syncOriginal() whenever you call '$model->setUnfillableAttributes($item);` .. so far, my tests show this to be correct.

@zoul0813
Copy link
Contributor Author

Ref #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baopham @zoul0813