Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActionSheet.java #17

Merged
merged 1 commit into from Dec 10, 2015
Merged

Conversation

baoyongzhang added a commit that referenced this pull request Dec 10, 2015
@baoyongzhang baoyongzhang merged commit f30a03e into baoyongzhang:master Dec 10, 2015
@brx0826
Copy link
Contributor Author

brx0826 commented Dec 10, 2015

Thank you!
Is it possible for me to download new changes via Gradle?

@brx0826
Copy link
Contributor Author

brx0826 commented Dec 10, 2015

Thank you!

Would you update gradle so that I can install your control via gradle?

Thanks a lot,
Rixian

On Thu, Dec 10, 2015 at 10:59 AM, Mr.Bao notifications@github.com wrote:

Merged #17 #17.


Reply to this email directly or view it on GitHub
#17 (comment)
.

@baoyongzhang
Copy link
Owner

Hi, please wait.

@baoyongzhang
Copy link
Owner

It's ok now.

compile 'com.baoyz.actionsheet:library:1.1.4'

@brx0826
Copy link
Contributor Author

brx0826 commented Dec 10, 2015

Hello Mr.Bao,

It's much better now, but it is still crashing.

Here are my suggestions;

  1. I changed this part of code;
    @OverRide public void onSaveInstanceState(Bundle outState) { super.
    onSaveInstanceState(outState); outState.putBoolean(EXTRA_DISMISSED,
    mDismissed); }
    to

@OverRide public void onSaveInstanceState(Bundle outState) {
outState.putBoolean(EXTRA_DISMISSED, mDismissed); }

And you didn't approve this change, right?
Is this a problem? I saw they wrote on stackoverflow that this
"super.onSaveInstanceState(outState);" is causing bugs from API Level 11.
What is your opinion on this?

  1. Can we put the following code inside show function also in new Handler().
    post(new Runnable() { }); ?

FragmentTransaction ft = manager.beginTransaction(); ft.add(this, tag); ft.
addToBackStack(null); ft.commitAllowingStateLoss();

I made those changes and issued a pull request.
Please check.

Best Regards,
Rixian

On Thu, Dec 10, 2015 at 2:45 PM, Mr.Bao notifications@github.com wrote:

It's ok now.

compile 'com.baoyz.actionsheet:library:1.1.4'


Reply to this email directly or view it on GitHub
#17 (comment)
.

@brx0826
Copy link
Contributor Author

brx0826 commented Dec 13, 2015

Hello Mr.Bao,

I'd really appreciate it if you can check my pull request and reply me.

Thank you so much,
Rixian

On Thu, Dec 10, 2015 at 4:10 PM, rixian bai brx0826@gmail.com wrote:

Hello Mr.Bao,

It's much better now, but it is still crashing.

Here are my suggestions;

  1. I changed this part of code;
    @OverRide public void onSaveInstanceState(Bundle outState) { super.
    onSaveInstanceState(outState); outState.putBoolean(EXTRA_DISMISSED,
    mDismissed); }
    to

@OverRide public void onSaveInstanceState(Bundle outState) {
outState.putBoolean(EXTRA_DISMISSED, mDismissed); }

And you didn't approve this change, right?
Is this a problem? I saw they wrote on stackoverflow that this
"super.onSaveInstanceState(outState);" is causing bugs from API Level 11.
What is your opinion on this?

  1. Can we put the following code inside show function also in new Handler
    ().post(new Runnable() { }); ?

FragmentTransaction ft = manager.beginTransaction(); ft.add(this, tag); ft
.addToBackStack(null); ft.commitAllowingStateLoss();

I made those changes and issued a pull request.
Please check.

Best Regards,
Rixian

On Thu, Dec 10, 2015 at 2:45 PM, Mr.Bao notifications@github.com wrote:

It's ok now.

compile 'com.baoyz.actionsheet:library:1.1.4'


Reply to this email directly or view it on GitHub
#17 (comment)
.

@brx0826
Copy link
Contributor Author

brx0826 commented Dec 14, 2015

Once you review, approve my pull request and generate a new Gradle Version, I will mark the issue I created as resolved.
I really need your help in this urgently.
Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants