Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of additional option settings #5

Closed
baptiste0928 opened this issue Nov 2, 2021 · 1 comment
Closed

Validation of additional option settings #5

baptiste0928 opened this issue Nov 2, 2021 · 1 comment
Labels
breaking Introduce breaking changes. enhancement New feature or request

Comments

@baptiste0928
Copy link
Owner

Actually, additional settings like channel_types are supported with the CreateCommand trait, but are not enforced when parsing command data. These settings should be provided to the from_option method of the CommandOption trait, which will introduce a breaking change.
@baptiste0928 baptiste0928 added enhancement New feature or request breaking Introduce breaking changes. labels Nov 2, 2021
@baptiste0928
Copy link
Owner Author

Implemented in f7797b4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Introduce breaking changes. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baptiste0928