Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated dependencies #84

Open
onitake opened this issue Oct 24, 2022 · 1 comment
Open

Outdated dependencies #84

onitake opened this issue Oct 24, 2022 · 1 comment

Comments

@onitake
Copy link

onitake commented Oct 24, 2022

The Python module versions in requirements.txt are a bit outdated.

I installed all the dependencies using my system's package manager, and while those packages aren't all at the latest version, some of them are quite far ahead of those in requirements.txt.
These are the versions I have tested:
numpy: 1.21.5
matplotlib: 3.5.2
scipy: 1.8.1
sympy: 1.10.1

There weren't any issues, except for a deprecation in matplotlib 3.6 (changelog is here):

MatplotlibDeprecationWarning: Calling gca() with keyword arguments was deprecated in Matplotlib 3.4. Starting two minor releases later, gca() will take no keyword arguments. The gca() function should only be used to get the current axes, or if no axes exist, create new axes with default keyword arguments. To create a new axes with non-default arguments, use plt.axes() or plt.subplot().
  ax = fig.gca(projection='3d')

The fix for this actually quite easy: Replace

ax = fig.gca(projection='3d')

with

ax = fig.add_subplot(projection='3d')

Also, when I checked the matplotlib 2.2.x documentation, it didn't even mention the projection argument on the gca() function.

Please update the dependency list to more recent versions.

You could also use compatible versions instead of exact versions. For example:

# requirements.txt
ipywidgets ~=8.0
jupyter ~=1.0.0
numpy ~=1.23
matplotlib ~=3.6.0
scipy ~=1.9
sympy ~=1.11
@bugleilei
Copy link

bugleilei commented Oct 24, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants