Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer of the removed fluid in hydro module will lose information in a restart simulation #15

Open
piyueh opened this issue Dec 12, 2018 · 6 comments

Comments

@piyueh
Copy link
Member

piyueh commented Dec 12, 2018

If a simulation is a restart session, then the tracer will lose the information from the previous simulation. But given that land-spill simulations are usually very short, restarting does not required frequently. So this issue will not be addressed in the near future.

@mandli
Copy link
Collaborator

mandli commented Dec 13, 2018

One thing of note, if the tracer value is stored in the q array then it will be available. The entirety of the alloc array, which stores the grid data, aux data, etc., all gets saved (hence the size of the restart files).

@piyueh
Copy link
Member Author

piyueh commented Dec 13, 2018

Thank you @mandli. The reason I didn't use q array for the tracer is that only cells surrounding water bodies have values in the tracer. Using q array for this purpose will waste memory on cells that will never have non-zero values.

@mandli
Copy link
Collaborator

mandli commented Dec 13, 2018

Ah, so you are storing things in a very small part of the domain yourself?

@piyueh
Copy link
Member Author

piyueh commented Dec 13, 2018

Not really. The tracer is a fixed Cartesian mesh (or says, a raster in GIS terminology) covering the whole computational domain. But the data on this "tracer mesh" is not a dense array, unlike q or aux. The data is a sparse matrix in CSR format. And the locations of non-zero entries in this sparse matrix are the cells surrounding water bodies. So, no matter how many cells are in this tracer mesh in total, the memory consumed is only relevant to the number of cells surrounding water bodies.

@mandli
Copy link
Collaborator

mandli commented Dec 14, 2018

Now I understand, this is not actually for the oil itself but the oil in the water.

@piyueh
Copy link
Member Author

piyueh commented Dec 14, 2018

Yes, you're right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants