Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Electron (or not?) #30

Closed
batuhan opened this issue May 9, 2016 · 3 comments
Closed

support Electron (or not?) #30

batuhan opened this issue May 9, 2016 · 3 comments
Labels

Comments

@batuhan
Copy link
Contributor

batuhan commented May 9, 2016

I'll convert barbar/riothamus to TypeScript and couldn't decide if I should push the Electron-specific edits back to Vortigern or fork Vortigern to create another boilerplate for Electron.

Any ideas?

@batuhan
Copy link
Contributor Author

batuhan commented May 9, 2016

Keep in mind that some parts of the Vortigern like the isomorphic render are not needed in an Electron project. With that in mind, I think best course is to forking and simplifying Vortigern. (removing unnecessary parts and adding Electron-specific code, like example usages)

@altaywtf
Copy link
Contributor

altaywtf commented May 9, 2016

As you said, we can do it in a separate repo. It would be great to have similar configurations and structure. I was also considering to prepare a simplified, only client-side rendered version of vortigern for smaller (or toy) projects.

@batuhan
Copy link
Contributor Author

batuhan commented May 9, 2016

It's settled then. I'll merge the PR I have opened here, after that I'll start working on this.

@batuhan batuhan closed this as completed May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants