Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian SBAS (SDCM) L1 label is missing #585

Closed
barbeau opened this issue Apr 11, 2022 · 8 comments
Closed

Russian SBAS (SDCM) L1 label is missing #585

barbeau opened this issue Apr 11, 2022 · 8 comments
Labels
bug your-first-pr A good place for new contributors to start work
Milestone

Comments

@barbeau
Copy link
Owner

barbeau commented Apr 11, 2022

Describe the bug
A user provided this screenshot, which shows that the Russian SDCM SBAS satellites aren't showing the L1 label correctly:

image

I should also review to make sure that all other SBAS are fully implemented. Looking at CarrierFreqUtils.getSbasCf(), it looks like we have mappings for the following SBAS:

  1. EGNOS (EU)
  2. MSAS (Japan)
  3. GAGAN (India)
  4. WAAS (US)

To Reproduce
Steps to reproduce the behavior:

  1. Be in view of Russian SBAS satellite

Expected behavior
Carrier frequency of 1575.42 should be shown as L1.

Observed behavior
Raw CF is shown instead

App, Device and Android version:

App version: v3.9.16 (18093-google)
Model: SM-S908U1 (Samsung Galaxy S22 Ultra unlocked)
Android version: 12 / 31
GNSS HW year: 2020
GNSS HW name: qcom,SM_WAIPIO,MPSS.DE.1.0.c4-00029-WAIPIO_GEN_PACK-1.3475.171,

Screenshots:

Can be created by pressing the Volume Down and Power Button at the same time on Android 4.0 and higher.

@barbeau barbeau added the bug label Apr 11, 2022
@barbeau barbeau added this to the v4.0 milestone Apr 11, 2022
@barbeau
Copy link
Owner Author

barbeau commented Apr 12, 2022

Here are the SBAS we currently support (i.e., show a flag for instead of leaving it blank as unknown):

fun Int.toSbasType(): SbasType {
        if (this == 120 || this == 123 || this == 126 || this == 136) {
            return SbasType.EGNOS
        } else if (this == 125 || this == 140 || this == 141) {
            return SbasType.SDCM
        } else if (this == 130 || this == 143 || this == 144) {
            // Also referred to as BDSBAS
            return SbasType.SNAS
        } else if (this == 131 || this == 133 || this == 135 || this == 138) {
            return SbasType.WAAS
        } else if (this == 127 || this == 128 || this == 139) {
            return SbasType.GAGAN
        } else if (this == 129 || this == 137) {
            return SbasType.MSAS
        }
        return SbasType.UNKNOWN
    }

We should support all the same svids for CFs.

@barbeau
Copy link
Owner Author

barbeau commented Jun 22, 2022

For more info on SVIDs of SBAS see:
https://www.igs.org/mgex/constellations#sbas

@barbeau barbeau added the your-first-pr A good place for new contributors to start work label Aug 18, 2022
@barbeau
Copy link
Owner Author

barbeau commented Apr 4, 2023

Fixed by 08cb7b5

@barbeau barbeau closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug your-first-pr A good place for new contributors to start work
Projects
None yet
Development

No branches or pull requests

2 participants
@barbeau and others