Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBAN for France : Branch setup to add #30

Closed
johannbart opened this issue Mar 23, 2021 · 3 comments
Closed

IBAN for France : Branch setup to add #30

johannbart opened this issue Mar 23, 2021 · 3 comments

Comments

@johannbart
Copy link

Hello,

thanks for this API, really appreciate !

The setup for France is incomplete.

You should add :

  • Bank 5 digits from 5 to 9 (already done)
  • Branch 5 digits from 10 to 14

Source 1 : https://fr.wikipedia.org/wiki/International_Bank_Account_Number
Source 2 : I am french. :-)

Thanks.

@johannbart johannbart changed the title IBAN for France : Branch issue IBAN for France : Branch setup to add Mar 23, 2021
@barend
Copy link
Owner

barend commented Mar 23, 2021

Hi, thanks for the improvement suggestion!

The reason the branch identifier is not there is because it's not listed in the official SWIFT IBAN Registry PDF [1], currently release 89 (page 30). What's interesting is that it does list the IBAN structure as FR2!n5!n5!n11!c2!n with both of the 5!n blocks, so it's kinda-sorta there, but it's not explicitly included in the structure table.

I originally started out with IBAN information from tons of different sources, and that got really confusing, so I'm now only using two (and that would have been one, but I didn't want to break compatibility). I suppose in this case it's clear enough, but I want to avoid taking my reference information from tons of diferent places again.

I'll leave this issue open for now and fix it when I bake the next release. I'm now one version behind the IBAN Registry, so I should do a maintaince release soon.

[1] https://www.swift.com/standards/data-standards/iban-international-bank-account-number

@johannbart
Copy link
Author

Thanks for the super fast feedback. :-)

@barend barend closed this as completed in e366cc4 Apr 3, 2021
@barend
Copy link
Owner

barend commented Apr 3, 2021

@johannbart I have just released version 1.9.0 to Maven Central. It'll take a bit of time to drip through the CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants