Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add South Sudan SD Length 18 #42

Closed
firehooper opened this issue Aug 16, 2021 · 3 comments
Closed

Add South Sudan SD Length 18 #42

firehooper opened this issue Aug 16, 2021 · 3 comments

Comments

@firehooper
Copy link

No description provided.

@barend
Copy link
Owner

barend commented Aug 18, 2021

Hi firehooper,

Thank you for informing me that there have been changes to the IBAN Registry since the last release. I no longer work with IBAN's daily, so it's a little bit out of view and I missed the update. I'll prepare a new release of the library soon.

One request: please keep in mind that there's a human being on the other side. Your message is provides the necessary information, and it's helpful that you took the time to send it, but it's a bit light on social protocol. You absolutely do not have to write me a twenty page email, but I do appreciate some sort of basic greeting. Thanks.

Barend

@firehooper
Copy link
Author

Hi @barend sorry for the brevity. Thank you so much for this library! This is a low priority as we use the SWIFT Ref files directly for most projects now to load the IBAN structure at runtime, but we started using this library before that. This was mostly a TODO for myself or anyone depending on the library to not forget to submit a PR like this one: #7 . So my intent was humane even if the written word did not indicate such.

@barend barend closed this as completed in f88ff9c Aug 20, 2021
@barend
Copy link
Owner

barend commented Aug 20, 2021

Hi @firehooper, thanks for the reply; all good. I just published version 1.10.1 to Maven Central that includes the IBAN spec for Sudan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants